feat: remove MSSQL_PID env var from Mssql

Deffiss / testenvironment-docker

MIT License

117 stars 30 forks source link

feat: remove MSSQL_PID env var from Mssql #75

Closed ZaoralJ closed 1 year ago

ZaoralJ commented 1 year ago

Removing MSSQL_PID from Mssql container will enable to use AzureSqlEdge image. It's not possible because predefined MSSQL_PID=Express is not supported by AzureSqlEdge and container fail to start.

SqlServer allows these MSSQL_PID:

Evaluation
Developer
Express
Web
Standard
Enterprise
A product key in format #####-#####-#####-#####-#####, where '#' is a number or a letter

AzureSqlEdge allows these MSSQL_PID:

Developer
Enterprise

Let's get start container with default MSSQL_PID.

Deffiss commented 1 year ago

Great! I like this approach more than adding a new type of container with 99% same codebase. If this works for you as well, let's stick to this option?

ZaoralJ commented 1 year ago

Great! I like this approach more than adding a new type of container with 99% same codebase. If this works for you as well, let's stick to this option?

It works for me. AzureSqlEdge is not really DRY, but I didn't want to start making big changes to share code with Mssql. I hope SQL server will run in arm64 soon.

Deffiss commented 1 year ago

@ZaoralJ - version 2.1.6 is published.