search

DefiLlama / dimension-adapters

91 stars 1.01k forks source link

Adapter for daily fees and daily revenue data, for assetchain blockchain #2029

Closed theiceeman closed 2 weeks ago

llamatester commented 3 weeks ago

The assetchain.ts adapter exports:

> adapters@1.0.0 test
> ts-node --transpile-only cli/testAdapter.ts fees assetchain.ts

🦙 Running ASSETCHAIN.TS adapter 🦙
---------------------------------------------------
Start Date: Mon, 21 Oct 2024 02:33:20 GMT
End Date:   Tue, 22 Oct 2024 02:33:20 GMT
---------------------------------------------------

ASSETCHAIN 👇
Backfill start time: 29/8/2020
NO METHODOLOGY SPECIFIED
Daily fees: 0
Daily revenue: 0
End timestamp: 1729564399 (2024-10-22T02:33:19.000Z)
theiceeman commented 3 weeks ago

Hello @0xngmi can you review this pr pls Or is there something still missing on our end. Thanks

g1nt0ki commented 3 weeks ago

@theiceeman sorry for the delay, reviewing it now

llamatester commented 3 weeks ago

The assetchain.ts adapter exports:

> adapters@1.0.0 test
> ts-node --transpile-only cli/testAdapter.ts fees assetchain.ts

🦙 Running ASSETCHAIN.TS adapter 🦙
---------------------------------------------------
Start Date: Wed, 23 Oct 2024 05:05:30 GMT
End Date:   Thu, 24 Oct 2024 05:05:30 GMT
---------------------------------------------------

ASSETCHAIN 👇
Backfill start time: 29/8/2020
NO METHODOLOGY SPECIFIED
Daily fees: 0
Daily revenue: 0
End timestamp: 1729746329 (2024-10-24T05:05:29.000Z)
llamatester commented 2 weeks ago

The assetchain.ts adapter exports:

> adapters@1.0.0 test
> ts-node --transpile-only cli/testAdapter.ts fees assetchain.ts

🦙 Running ASSETCHAIN.TS adapter 🦙
---------------------------------------------------
Start Date: Thu, 24 Oct 2024 05:40:09 GMT
End Date:   Fri, 25 Oct 2024 05:40:09 GMT
---------------------------------------------------

ASSETCHAIN 👇
Backfill start time: 29/8/2020
NO METHODOLOGY SPECIFIED
Daily fees: 0
Daily revenue: 0
End timestamp: 1729834808 (2024-10-25T05:40:08.000Z)
dtmkeng commented 2 weeks ago

@theiceeman i try refill data but it still 0 every day is it correct ?

theiceeman commented 2 weeks ago

Let me confirm this pls Thank you

theiceeman commented 2 weeks ago

Hello @dtmkeng I reviewed this, and there was an issue with the value. My update still returns zero, but thats because the fees generated currently are very small. Less than 0.

It seems DefiLlama rounds values like that to 0. Pls merge the update i made below. Thanks.

https://github.com/DefiLlama/dimension-adapters/pull/2061