Closed ethzoomer closed 2 months ago
gm, pls add poolMeta (see velodrome-v2), also url fields to the individual pools would be very helpful
@slasher125 Ty will do, is it cool if I also add aerodrome-slipstream poolMeta
and url
in this PR while I'm at it?
yes
The aerodrome-slipstream adapter exports pools:
Test Suites: 1 passed, 1 total Tests: 536 passed, 536 total Snapshots: 0 total Time: 0.446 s Ran all test suites.
Nb of pools: 76
Sample pools:
┌─────────┬──────────────────────────────────────────────┬────────┬────────────────────────┬───────────────┬────────────────────┬────────────────────┬──────────────────────────────────────────────────┬────────────────────────────────────────────────────────────────────────────────────────────────┬─────────────────┬─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ (index) │ pool │ chain │ project │ symbol │ tvlUsd │ apyReward │ rewardTokens │ underlyingTokens │ poolMeta │ url │
├─────────┼──────────────────────────────────────────────┼────────┼────────────────────────┼───────────────┼────────────────────┼────────────────────┼──────────────────────────────────────────────────┼────────────────────────────────────────────────────────────────────────────────────────────────┼─────────────────┼─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ 0 │ '0x47cA96Ea59C13F72745928887f84C9F52C3D7348' │ 'Base' │ 'aerodrome-slipstream' │ 'cbETH-WETH' │ 17821364.95669273 │ 11.445245183162745 │ [ '0x940181a94A35A4569E4529A3CDfB74e38FD98631' ] │ [ '0x2Ae3F1Ec7F1F5012CFEab0185bfc7aa3cf0DEc22', '0x4200000000000000000000000000000000000006' ] │ 'CL1 - 0.05%' │ 'https://aerodrome.finance/deposit?token0=0x2Ae3F1Ec7F1F5012CFEab0185bfc7aa3cf0DEc22&token1=0x4200000000000000000000000000000000000006&type=1&factory=0x5e7BB104d84c7CB9B682AaC2F3d509f5F406809A' │
│ 1 │ '0x0c1A09d5D0445047DA3Ab4994262b22404288A3B' │ 'Base' │ 'aerodrome-slipstream' │ 'USDC-USD+' │ 14399324.001226243 │ 50.14865263062098 │ [ '0x940181a94A35A4569E4529A3CDfB74e38FD98631' ] │ [ '0x833589fCD6eDb6E08f4c7C32D4f71b54bdA02913', '0xB79DD08EA68A908A97220C76d19A6aA9cBDE4376' ] │ 'CL1 - 0.01%' │ 'https://aerodrome.finance/deposit?token0=0x833589fCD6eDb6E08f4c7C32D4f71b54bdA02913&token1=0xB79DD08EA68A908A97220C76d19A6aA9cBDE4376&type=1&factory=0x5e7BB104d84c7CB9B682AaC2F3d509f5F406809A' │
│ 2 │ '0xb2cc224c1c9feE385f8ad6a55b4d94E92359DC59' │ 'Base' │ 'aerodrome-slipstream' │ 'WETH-USDC' │ 14311029.86402668 │ 2577.4546603678255 │ [ '0x940181a94A35A4569E4529A3CDfB74e38FD98631' ] │ [ '0x4200000000000000000000000000000000000006', '0x833589fCD6eDb6E08f4c7C32D4f71b54bdA02913' ] │ 'CL100 - 0.04%' │ 'https://aerodrome.finance/deposit?token0=0x4200000000000000000000000000000000000006&token1=0x833589fCD6eDb6E08f4c7C32D4f71b54bdA02913&type=100&factory=0x5e7BB104d84c7CB9B682AaC2F3d509f5F406809A' │
│ 3 │ '0x98c7A2338336d2d354663246F64676009c7bDa97' │ 'Base' │ 'aerodrome-slipstream' │ 'USDC-USDbC' │ 11789659.958305176 │ 14.809868516685803 │ [ '0x940181a94A35A4569E4529A3CDfB74e38FD98631' ] │ [ '0x833589fCD6eDb6E08f4c7C32D4f71b54bdA02913', '0xd9aAEc86B65D86f6A7B5B1b0c42FFA531710b6CA' ] │ 'CL1 - 0.01%' │ 'https://aerodrome.finance/deposit?token0=0x833589fCD6eDb6E08f4c7C32D4f71b54bdA02913&token1=0xd9aAEc86B65D86f6A7B5B1b0c42FFA531710b6CA&type=1&factory=0x5e7BB104d84c7CB9B682AaC2F3d509f5F406809A' │
│ 4 │ '0x861A2922bE165a5Bd41b1E482B49216b465e1B5F' │ 'Base' │ 'aerodrome-slipstream' │ 'WETH-wstETH' │ 10641333.521021914 │ 10.956613305477063 │ [ '0x940181a94A35A4569E4529A3CDfB74e38FD98631' ] │ [ '0x4200000000000000000000000000000000000006', '0xc1CBa3fCea344f92D9239c08C0568f6F2F0ee452' ] │ 'CL1 - 0.01%' │ 'https://aerodrome.finance/deposit?token0=0x4200000000000000000000000000000000000006&token1=0xc1CBa3fCea344f92D9239c08C0568f6F2F0ee452&type=1&factory=0x5e7BB104d84c7CB9B682AaC2F3d509f5F406809A' │
│ 5 │ '0x2ae9DF02539887d4EbcE0230168a302d34784c82' │ 'Base' │ 'aerodrome-slipstream' │ 'WETH-bsdETH' │ 4910556.543749326 │ 13.53666234947104 │ [ '0x940181a94A35A4569E4529A3CDfB74e38FD98631' ] │ [ '0x4200000000000000000000000000000000000006', '0xCb327b99fF831bF8223cCEd12B1338FF3aA322Ff' ] │ 'CL1 - 0.3%' │ 'https://aerodrome.finance/deposit?token0=0x4200000000000000000000000000000000000006&token1=0xCb327b99fF831bF8223cCEd12B1338FF3aA322Ff&type=1&factory=0x5e7BB104d84c7CB9B682AaC2F3d509f5F406809A' │
│ 6 │ '0x82321f3BEB69f503380D6B233857d5C43562e2D0' │ 'Base' │ 'aerodrome-slipstream' │ 'WETH-AERO' │ 3224745.277496624 │ 1232.336688579906 │ [ '0x940181a94A35A4569E4529A3CDfB74e38FD98631' ] │ [ '0x4200000000000000000000000000000000000006', '0x940181a94A35A4569E4529A3CDfB74e38FD98631' ] │ 'CL200 - 0.6%' │ 'https://aerodrome.finance/deposit?token0=0x4200000000000000000000000000000000000006&token1=0x940181a94A35A4569E4529A3CDfB74e38FD98631&type=200&factory=0x5e7BB104d84c7CB9B682AaC2F3d509f5F406809A' │
│ 7 │ '0x2092f4acbb18BB1649595DF59B9Cb601bBA1EBB7' │ 'Base' │ 'aerodrome-slipstream' │ 'WETH-RDNT' │ 3049539.166115868 │ 2906.644269543098 │ [ '0x940181a94A35A4569E4529A3CDfB74e38FD98631' ] │ [ '0x4200000000000000000000000000000000000006', '0xd722E55C1d9D9fA0021A5215Cbb904b92B3dC5d4' ] │ 'CL200 - 0.3%' │ 'https://aerodrome.finance/deposit?token0=0x4200000000000000000000000000000000000006&token1=0xd722E55C1d9D9fA0021A5215Cbb904b92B3dC5d4&type=200&factory=0x5e7BB104d84c7CB9B682AaC2F3d509f5F406809A' │
│ 8 │ '0x4e829F8A5213c42535AB84AA40BD4aDCCE9cBa02' │ 'Base' │ 'aerodrome-slipstream' │ 'WETH-BRETT' │ 2157388.704744478 │ 3134.2870524410555 │ [ '0x940181a94A35A4569E4529A3CDfB74e38FD98631' ] │ [ '0x4200000000000000000000000000000000000006', '0x532f27101965dd16442E59d40670FaF5eBB142E4' ] │ 'CL200 - 0.25%' │ 'https://aerodrome.finance/deposit?token0=0x4200000000000000000000000000000000000006&token1=0x532f27101965dd16442E59d40670FaF5eBB142E4&type=200&factory=0x5e7BB104d84c7CB9B682AaC2F3d509f5F406809A' │
│ 9 │ '0x4D69971CCd4A636c403a3C1B00c85e99bB9B5606' │ 'Base' │ 'aerodrome-slipstream' │ 'WETH-USD+' │ 1980761.2364014206 │ 4398.452353133199 │ [ '0x940181a94A35A4569E4529A3CDfB74e38FD98631' ] │ [ '0x4200000000000000000000000000000000000006', '0xB79DD08EA68A908A97220C76d19A6aA9cBDE4376' ] │ 'CL100 - 0.04%' │ 'https://aerodrome.finance/deposit?token0=0x4200000000000000000000000000000000000006&token1=0xB79DD08EA68A908A97220C76d19A6aA9cBDE4376&type=100&factory=0x5e7BB104d84c7CB9B682AaC2F3d509f5F406809A' │
└─────────┴──────────────────────────────────────────────┴────────┴────────────────────────┴───────────────┴────────────────────┴────────────────────┴──────────────────────────────────────────────────┴────────────────────────────────────────────────────────────────────────────────────────────────┴─────────────────┴─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
This adapter contains some pools with <10k TVL, these pools won't be shown in DefiLlama
@ethzoomer hey sir i wasn't paying enough attention when reviewing this and the velodrome v3 adapter: for concentrated liquidity pools we usually assume a much wider range than whats being applied in this adapter (eg for uni v3 we use +/- 30% for non stable and 0.1% range for stable pools)
so we need to modify this and other adapter to use much wider and more realistic ranges for eg 'CL100' and 'CL200' eg the wide range in here: https://velodrome.finance/deposit?token0=0x0b2C639c533813f4Aa9D7837CAf62653d097Ff85&token1=0x4200000000000000000000000000000000000006&type=100&factory=0xCc0bDDB707055e04e497aB22a59c2aF4391cd12F
i've temporarily disabled these pools from showing up on our ui until modified, can u apply these changes across both adapters?
Sounds good, I'll put in a PR switching the adaptor to use the "Wide" range methodology from the dapp
The velodrome-v3 adapter exports pools:
Test Suites: 1 passed, 1 total Tests: 228 passed, 228 total Snapshots: 0 total Time: 0.349 s Ran all test suites.