bug: some chains don't check for upgrades.

danbryan commented 1 year ago

https://twitter.com/rhinostake/status/1698394405760377072

For some reason, umee did not find a rest_server to use to check for upgrades despite the logs showing

Found 16 rest endpoints and 16 rpc endpoints for umee
Completed fetch data for network umee

{
  "type": "mainnet",
  "network": "umee",
  "rest_server": "",
  "rpc_server": "https://rpc-umee.cosmos-spaces.cloud",
  "latest_block_height": 8179463,
  "upgrade_found": false,
  "upgrade_name": "",
  "source": "",
  "upgrade_block_height": null,
  "estimated_upgrade_time": null,
  "version": ""
}

I think the problem is bigger than umee. We need to have checks to ensure each chain has at least one functional RPC/REST server from the CR.

pharr117 commented 1 year ago

This one is a problem here:

https://github.com/DefiantLabs/cosmos-upgrades/blob/a686a929fb196ad1546278d9f2134e36ad83d49f/app.py#L280-L282

A bunch of networks are returning empty healthy REST networks. This means either:

The chain.json file for the network has no rest endpoints
None of the REST servers presented in the chain.json (if any are provided) are responding to /health endpoint checks which we use to determine if the REST endpoint is healthy

I put in a guard for healthy rest endpoints checks and this happens a lot:

2023-09-04 14:17:42 No healthy REST endpoints found for network sei. Skipping...
2023-09-04 14:17:42 No healthy REST endpoints found for network acrechain. Skipping...
2023-09-04 14:17:43 No healthy REST endpoints found for network mises. Skipping...
2023-09-04 14:17:43 No healthy REST endpoints found for network arkh. Skipping...
2023-09-04 14:17:43 No healthy REST endpoints found for network likecoin. Skipping...
2023-09-04 14:17:44 No healthy REST endpoints found for network bostrom. Skipping...
2023-09-04 14:17:44 No healthy REST endpoints found for network 8ball. Skipping...

Not sure what the solution would be here, we are completely dependent on these rest endpoints.

pharr117 commented 1 year ago

Resolved by hitting an alternate endpoint to get a 200

DefiantLabs / cosmos-upgrades

bug: some chains don't check for upgrades. #9