DefinedNet / nebula-docs

Documentation for the Nebula open source project
https://nebula.defined.net/docs
12 stars 10 forks source link

Use corepack pnpm instead of volta npm #109

Closed jasikpark closed 9 months ago

jasikpark commented 9 months ago

This updates our node/package manager situation to depend on pnpm and corepack, similar to webclient/www

netlify[bot] commented 9 months ago

Deploy Preview for nebula-docs-dn ready!

Name Link
Latest commit 0c9e576221dfefcdff4daeef54fef894dd405925
Latest deploy log https://app.netlify.com/sites/nebula-docs-dn/deploys/6542647b7d735a0008d335b6
Deploy Preview https://deploy-preview-109--nebula-docs-dn.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

IanVS commented 9 months ago

Looks like we need to add @types/node to our package.json?

jasikpark commented 9 months ago

> nebula-docs@0.0.1 typecheck /home/runner/work/nebula-docs/nebula-docs
> tsc

error TS2688: Cannot find type definition file for '@docusaurus/theme-classic'.
  The file is in the program because:
    Entry point of type library '@docusaurus/theme-classic' specified in compilerOptions
 ELIFECYCLE  Command failed with exit code 2.

I can't replicate this locally 🫠

IanVS commented 9 months ago

I can. Maybe try clearing your typescript cache?

IanVS commented 9 months ago

This looks like a much bigger PR than just moving from volta to pnpm. Let's tone it down a bit, and maybe just use regular npm if pnpm is giving us problems. The main goal is to unblock John.

jasikpark commented 9 months ago

This looks like a much bigger PR than just moving from volta to pnpm. Let's tone it down a bit, and maybe just use regular npm if pnpm is giving us problems. The main goal is to unblock John.

only issue is that corepack doesn't support npm, so looks like John's commit on his own PR is the right way to go then

IanVS commented 9 months ago

Alright, then let's get his PR in, then scope this down to just migrating to pnpm?

jasikpark commented 9 months ago

reset to "just pnpm"

jasikpark commented 9 months ago

rebased