DefinedNet / nebula-docs

Documentation for the Nebula open source project
https://nebula.defined.net/docs
12 stars 10 forks source link

Color-code Nebula and regular IPs #141

Open jasikpark opened 1 month ago

jasikpark commented 1 month ago
netlify[bot] commented 1 month ago

Deploy Preview for nebula-docs-dn ready!

Name Link
Latest commit 22f6b530702d0ff44a024c95d8e0563ed6d4e64d
Latest deploy log https://app.netlify.com/sites/nebula-docs-dn/deploys/66686172816563000869fc7b
Deploy Preview https://deploy-preview-141--nebula-docs-dn.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

IanVS commented 1 month ago

I'm not 100% sure about using underlines here, it makes them look like links to me. And the color difference is pretty subtle / easy to miss. I'd want to have @bgolat take a look and give his take, at least. Brian, a good page to look at might be https://deploy-preview-141--nebula-docs-dn.netlify.app/docs/config/lighthouse/.

jasikpark commented 1 month ago

The styles are 100% up for debate, I just wanted to get something semi-reasonable up

bgolat commented 1 month ago

What is the context of this? I would avoid underlining text as a way to highlight since that it generally reserved for links.

jasikpark commented 1 month ago

Highlighting would probably be preferred then; the goal is to indicate when an IP or address refers to a Nebula overlay IP or an underlay IP from the regular network.