DefinitelyTyped / DefinitelyTyped

The repository for high quality TypeScript type definitions.
Other
47.72k stars 29.92k forks source link

`@types/forge-apis@0.8.3`: `ObjectIds` should be a `number` array or `undefined`. #61331

Open eunchurn opened 1 year ago

eunchurn commented 1 year ago

Hi! πŸ‘‹

Firstly, thanks for your work on this project! πŸ™‚

Today I used patch-package to patch @types/forge-apis@0.8.3 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/@types/forge-apis/index.d.ts b/node_modules/@types/forge-apis/index.d.ts
index b48e3db..0391f11 100755
--- a/node_modules/@types/forge-apis/index.d.ts
+++ b/node_modules/@types/forge-apis/index.d.ts
@@ -166,7 +166,7 @@ export interface JobPayloadInput {
 export interface JobObjOutputPayloadAdvanced {
     exportFileStructure?: string | undefined;
     modelGuid?: string | undefined;
-    objectIds?: string[] | undefined;
+    objectIds?: number[] | undefined;
 }

 export interface JobPayloadItem {

This issue body was partially generated by patch-package.

Grayson-code commented 1 year ago

https://github.com/Autodesk-Forge/forge-api-nodejs-client/blob/master/docs/JobObjOutputPayloadAdvanced.md

its string[] not num[] as defined in docs

eunchurn commented 1 year ago

Document was wrong. Actually string array was not accepted. By using API.