DefinitelyTyped / NugetAutomation

Automatically generate nuget packages for the DefinetlyTyped TypeScript definitions.
Other
26 stars 10 forks source link

Don't allow really long git-commit messages #17

Open staxmanade opened 8 years ago

staxmanade commented 8 years ago

A really large pull request in https://github.com/DefinitelyTyped/DefinitelyTyped/pull/8605 caused every package to be re-published to NuGet.

At the end of the script is a git commit -m {msg} command. The {msg} was so big that it was throwing an error saying the command line command was too long to execute. Causing the system to not succeed and end up re-publishing all nuget packages every 2 hours (see image)

image

After running it once manually and manually committing the change in https://github.com/DefinitelyTyped/NugetAutomation/commit/6d2a95975849749b496e48d12e199b9561dc2cfd it re-stabilized.

image

So we need to guard against a commit message that is too long.

image