DefinitelyTyped / definitelytyped.github.io

Website content for definitelytyped.org
http://definitelytyped.org
MIT License
239 stars 96 forks source link

Fix getter/setter section contains misinformation #78

Closed mootari closed 6 years ago

mootari commented 6 years ago

Removes the "Getter / Setter" section from the best practices guide because it violates TypeScript standards and best practices: The TypeScript guide on Do's and Don'ts explicitely states that optional parameters are to be preferred.

mootari commented 6 years ago

As a side note, a link to the TypeScript Do's and Don'ts should probably be featured prominently on that page, as those already cover most of the points.

mootari commented 6 years ago

I just realized that the section is meant to describe combined setters / getters with argument dependant return values. Sorry for the noise. (Could probably be made a bit more verbose though)