search

DefinitelyTyped / dt-mergebot

The bot which handles auto-merging your PRs
https://devblogs.microsoft.com/typescript/changes-to-how-we-manage-definitelytyped/
MIT License
112 stars 44 forks source link

Use pageInfo for pagination #355

Closed jablko closed 3 years ago

jablko commented 3 years ago

Instead of fetching every cursor, just fetch pageInfo.endCursor. Also, pageInfo.hasNextPage saves one final network request.

elibarzilay commented 3 years ago

Instead of fetching every cursor, just fetch endCursor from pageInfo. hasNextPage saves one final network request.

Did you mean to write:

Instead of fetching every cursor, just fetch endCursor from pageInfo.hasNextPage. Saves one final network request.

?

jablko commented 3 years ago

That could have been clearer, sorry. I've revised the description slightly.

elibarzilay commented 3 years ago

(Added the fixed text to the commit.)