search

DefinitelyTyped / dt-mergebot

The bot which handles auto-merging your PRs
https://devblogs.microsoft.com/typescript/changes-to-how-we-manage-definitelytyped/
MIT License
112 stars 44 forks source link

Replace fetch policy network-only -> no-cache #357

Closed jablko closed 3 years ago

jablko commented 3 years ago

If we're never going to consult the cache (fetchPolicy: "network-only") then don't waste memory storing results (fetchPolicy: "no-cache")?

I don't expect this is a lot of memory -- I expect the number of objects is on the order of the number of active PRs? IDs should keep us from storing multiple copies. On the other hand the serverless function can run for long periods?

elibarzilay commented 3 years ago

The funny thing is that you created this PR just when I was reading about the apollo cache policies, and thought that we can do this change.

But wouldn't it make sense to replace the other network-onlys too?

jablko commented 3 years ago

Absolutely -- I replaced the others now too :heavy_check_mark: