search

DefinitelyTyped / dt-mergebot

The bot which handles auto-merging your PRs
https://devblogs.microsoft.com/typescript/changes-to-how-we-manage-definitelytyped/
MIT License
112 stars 44 forks source link

Consider ⏳ emoji instead of ❌ for pending #365

Closed JoshuaKGoldberg closed 3 years ago

JoshuaKGoldberg commented 3 years ago

Hi! I love the live comment feature on DT pull requests. It's very useful.

Today was the first time I looked at it immediately after sending a PR and was alarmed for a brief moment at the ❌ s:

Screenshot of typescript-bot informatively commenting on https://github.com/DefinitelyTyped/DefinitelyTyped/pull/51228#issuecomment-778855433

Could we switch those to, say, ⏳ to indicate the task is pending, not failed? I'd be happy to make that change if you're up for it!

johnnyreilly commented 3 years ago

I think this is a great suggestion @JoshuaKGoldberg!

orta commented 3 years ago

I like it, let's do it

elibarzilay commented 3 years ago

The thing is that having these two ⏳✅ icons would look kind of like a wall of graphics and also they're kind of unrelated, no?

Are there better alternatives? Maybe 🤔😄? ✋👍? 🔄🆗? ❓❗?

JoshuaKGoldberg commented 3 years ago

Carrying this conversation to its inevitable conclusion:

Status 🤔

orta commented 3 years ago

I think the wall clock 🕐 and then the tick ✅ feels great - we can maybe keep the ❌ around for something which is a blocker on you (a.k.a no tests or edits config files)