Closed orta closed 3 years ago
https://github.com/DefinitelyTyped/DefinitelyTyped/pull/52586 would remove the other GH actions CI step which is what is allowing DT mergebot to think it's green right now
To automatically approve, you can just rerequest each check suite whose conclusion
is ACTION_REQUIRED
: https://docs.github.com/en/graphql/reference/mutations#rerequestchecksuite
I would recommend doing this on the condition that no files outside the types/
directory are added/removed/modified.
You can also do the same thing with the REST API if for some reason that’s easier, but you’ll need to use the databaseId
property instead of the id
property of the check suite as returned from the GraphQL API.
There’s also another way to do this at the repo/actions/runs level with the REST API, but that’s not available via GraphQL mutation, and it’s also very difficult to figure out the check run id from the check suite (I don’t think it can even be retrieved with GraphQL at all), so I don’t recommend that.
Confirming that this worked locally, triggering https://github.com/DefinitelyTyped/DefinitelyTyped/pull/52627
I'll merge and nurse the deploy
Cool, I watched https://github.com/DefinitelyTyped/DefinitelyTyped/pull/52626 get updated by the bot
New contributors to DT need to have their CI privileges set - this PR changes the DT mergebot to move those PRs directly into the maintainer's TODO list.
Major additions:
Switch from a GQL mutation to a REST api call for rerunning builds. See the source for the HACK comment re doing a REST call.
Collect the IDs of all such tests, so they're all triggered, rather than just the first found.
New
The CI is blocked
label if test runs need to be approved and this cannot be done automatically due to infra edits.When there are no infra edits, approve the build (by re-running it), and treat it as a test-in-progress. In this case, mostly treat the CI state as
unknown
(still running) for the welcome message etc since it'll be started now.Add an
info.tooManyFiles
field that tracks when we didn't see all of the files, and:info.possiblyEditsInfra
is true if such edits exist or there are too many files so we can't be sure. NewPossibly Edits Infrastructure
label reflects this.