DefinitelyTyped / dt-mergebot

The bot which handles auto-merging your PRs
https://devblogs.microsoft.com/typescript/changes-to-how-we-manage-definitelytyped/
MIT License
112 stars 44 forks source link

Revise the ready-to-merge message to be a bit less celebratory #419

Closed elibarzilay closed 3 years ago

elibarzilay commented 3 years ago

Since I think that the "great job" part can be confusingly read as an approving review for people who don't realize that it's not a human who said it. I also realized that it's what was making me accompany a PR blessing with my own comment clarifying that I'm making it possible to merge "if you're actually done" -- so I added the "whenever you think it's ready".