Confirm self-merge via :+1: reaction to bot comment

DefinitelyTyped / dt-mergebot

The bot which handles auto-merging your PRs

https://devblogs.microsoft.com/typescript/changes-to-how-we-manage-definitelytyped/

MIT License

112 stars 44 forks source link

Confirm self-merge via :+1: reaction to bot comment #422

Open LinqLover opened 3 years ago

LinqLover commented 3 years ago

Regarding the well-known bot message we all love:

I think it would be even nicer if PR creators only needed to give a :+1: reaction to the bot instead of writing a comment. Would this be possible or is the bot only triggered via new comments?

(Note to myself, the relevant lines of code appear to be here: https://github.com/DefinitelyTyped/dt-mergebot/blob/98d89b4b937ce9046a3913a7ef03080bdb9e6ffa/src/pr-info.ts#L418-L425)

elibarzilay commented 2 years ago

I'm not sure that this is a good idea... The reactions are less explicit, and mistaking them seems easier. Another point is that there are other reactions, some could mean an approval, and some a rejection. For example, if :+1: means "ready to merge", then I'd expect a :-1: to remove the self-merge...