The fix proposed here is, don't filter existing approvals out of Unreviewed: (and Unmerged:) pings. Instead, don't apply the unreviewed label/timeline to PRs that have reviews and are already in the maintainer queue.
The unreviewed timeline has two functions, I think:
Bumping unreviewed PRs to the maintainer queue.
Soliciting reviews (for PRs in the maintainer queue and ones that aren't).
It doesn't have a function if a PR in the maintainer queue has reviews?
Doesn't change the project column.
Shouldn't re-ping anyone.
The code already treats "unreviewed" as completely unreviewed vs. unreviewed by maintainers, I think:
Motivated by a trivial cosmetic glitch (spurious
/) in theUnmerged:nearlycomment:It was introduced in a change that instead targeted this
Unreviewed:comment.The fix proposed here is, don't filter existing approvals out of
Unreviewed:(andUnmerged:) pings. Instead, don't apply the unreviewed label/timeline to PRs that have reviews and are already in the maintainer queue.The unreviewed timeline has two functions, I think:
It doesn't have a function if a PR in the maintainer queue has reviews?
The code already treats "unreviewed" as completely unreviewed vs. unreviewed by maintainers, I think:
This change:
Unmerged:andUnreviewed:comments).