Closed Maxim-Mazurok closed 2 years ago
Hi guys, any idea how to fix this? We've removed // TypeScript Version
from types and I'd like to create a PR to update all gapi.client.*
DT types, but I'm afraid that mergebot will fail on a huge PR again. I'm happy to still give it a try if that'll help in your investigation. Perhaps @andrewbranch or @elibarzilay could help? Thank you!
sigh ... and just today I deleted my fork of this repo since it was stale :)
Anyway, I tried to run it manually, and the problem is as follows:
The GH webhook attention span is very short (maybe ~2m?) which is irrelevant since the function should continue doing its thing which results in the actions visible on the PR, but I think that after 10m the azure function execution gets too bored too, and kills the whole thing, which explains the bot's speechlessness.
@Maxim-Mazurok, the bottom line for you is unfortunately-hopefully unchanged... "Unfortunate" because you'd need to do the splitting anyway to get such changes through in a timely manner, "hopefully" because the delays should come from the person on DT rotation who would need to scan all of the changes to ensure nothing bad in it but given that humans are humans it's likely for that person to look at the first few hundred changes and merge with a shrug. (I know I would do just that :)
In any case, #448 should fix that.
That all makes sense, I was expecting something along those lines, thank you for looking into that and for the quick hopefully-fix :)
PR I'm going to open will likely be just removing the same line from all packages, so I expect it can be easily mass-reviewed using some combination of git diff
and uniq
commands, or with an above-mentioned shrug :) I will try to keep non-humanly reviewable PRs to a minimum tho, cheers!
Heh, consider the fact that cloning DT takes a good amount of time and space, and that using plain git
to fetch a PR branch from a different repo can be confusing, and it's not surprising that it's not done too often given the volume of PRs.
But yeah, something like git diff ... | grep '^[+-]' | grep -vE '^(\+\+\+|---) [ab]/' | sort -u
is probably going to make it easy to scan. Maybe include instructions for how to fetch the branch and run the diff would make it easier to review if you have more of these in the future...
@elibarzilay the bot didn't comment on this huge PR: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/62446 Even though CI failed, I think it still should've picked it up and commented "The CI build failed", same as in https://github.com/DefinitelyTyped/DefinitelyTyped/pull/62399 Might need to re-open this issue, @andrewbranch Thank you!
I tried to run it locally, and it's still a pretty long run, but it takes 6m, which I thought is under the azure function timeout.
The thing that takes most of the time there, BTW, is getting owners for around 460 packages -- I'm guessing that it's slower because it fetches old files which take more time to recover. It uses the api for that, but ultimately it will end up digging into the git repo to get it all.
Someone (@andrewbranch?) with access to that should look at whether the timeout is shorter than that, and either
TOO_MANY_FILES
in pr-query.ts
)
TL;DR: when opening huge PRs, such as https://github.com/DefinitelyTyped/DefinitelyTyped/pull/62106 - mergebot never picks it up.
Other huge PRs that it didn't pick up: