search

DefinitelyTyped / dt-mergebot

The bot which handles auto-merging your PRs
https://devblogs.microsoft.com/typescript/changes-to-how-we-manage-definitelytyped/
MIT License
112 stars 44 forks source link

Ensure we don't ignore package.json only changes for calculating owners #494

Closed jakebailey closed 5 months ago

jakebailey commented 5 months ago

Noticed that https://github.com/DefinitelyTyped/DefinitelyTyped/pull/69589 was somehow missing the edits owners label. Turns out we special cased looking at PRs without index.d.ts changes.

~A better fix would be to always do await getOwnersOfPackage(name, headId, fetchFile); since it knows when to look for package.json/index.d.ts, but we have old tests that don't have index.d.ts in their VFS since PRs that didn't modify that file never fetched it. So, we can just expand the special case.~ I just fixed the tests to do it right.