search

Defman21 / komodo-terminal-butterfly

Docks the Butterfly terminal in Komodo
https://defman.me/projects/komodo-terminal/
Other
8 stars 3 forks source link

Support color scheme colors for the terminal #5

Open Defman21 opened 8 years ago

Defman21 commented 8 years ago

I'd have to generate a valid less code with @colors variable in it and use it later in skin/terminal.less. This should be generated before widget.js->loadStyleSheet will be called.

Defman21 commented 8 years ago

Gonna to use resource:// thing though (as Komodo does for the skin part)

Defman21 commented 8 years ago

Note: should use ko/colorscheme

require('ko/colorscheme').get('editor-scheme').getCommon(<common_name>, 'fore')

See CommonStyles for <common_name>.

Naatan commented 8 years ago

You could just have your stylesheet import the colors from the colorscheme and use them that way, ie:

@import url("chrome://komodo/skin/global/colors.less");
@import url("resource://profile/colors.less");

...
Defman21 commented 8 years ago

Hmm, probably scc status will give me all the colors I want.

Naatan commented 8 years ago

I would not recommend you use color variables for things that they were not intended for.

Naatan commented 8 years ago

Our color schemes have no explicit color definitions (eg. red = xx, blue = xx, ..), so I'm not sure how you would be able to do this in a way that wouldn't be hacky.

Defman21 commented 8 years ago

I'm not sure there's a non-hacky way. I want to rely on current color scheme and just use some colors from it. I don't see any others way for this except for adding a new preferences page for choosing your own 16 colors.