Defman21 / komodo-terminal-butterfly

Docks the Butterfly terminal in Komodo
https://defman.me/projects/komodo-terminal/
Other
8 stars 3 forks source link

Terminals become corrupt after a while #8

Open Naatan opened 8 years ago

Naatan commented 8 years ago

I've not really seen consistent steps to reproduce for this, but I think it simply happens after letting it idle for a while. I'll dig in the next time it happens and will provide more details.

Defman21 commented 8 years ago

This seems like terminal tabs loses connection to the butterfly server. But yeah I'll wait for any logs

Defman21 commented 8 years ago

Also, did it happen only to opened terminals or you lost ability to open new terminals as well? If you don't remember and reproduce this again, please answer this question :)

Naatan commented 8 years ago

Just to opened terminals.

Defman21 commented 8 years ago

So the server was fine then, the worst case is the bug is Butterfly bug. I'll try to reproduce it tomorrow with my browser and Komodo. It rely on WebSockets a lot, so I guess tabs should ping the server sometime or it will drop the connection.

Naatan commented 8 years ago

Reproduced, this is what it looks like:

image

No errors that I can find. The DOMi shows that no content is inserted (it had content before):

image

Manually navigating to http://localhost:57575/ works.

I think this is a bug with Butterfly.

Naatan commented 8 years ago

Gonna try and leave a session running in my browser.

Defman21 commented 8 years ago

https://github.com/Defman21/komodo-terminal-butterfly/issues/3 looks same, at least I had the same black screen but opening a new tab shows the terminal.