search

DeformableFriends / NeuralTracking

Official implementation for the NeurIPS 2020 paper Neural Non-Rigid Tracking.
https://www.niessnerlab.org/projects/bozic2020nnrt.html
MIT License
185 stars 37 forks source link

does not recognize align_corners = True in torch.grid sample #1

Closed maorp closed 3 years ago

maorp commented 3 years ago

Hi. first thanks for the wonderful paper and implementation. i cant run it without removing all align_corners argumants. its not recognized by torch grid sample function. I installed on windows 10 according to the directions. it installed pytorch 1.2 on my machine. maybe it needs 1.4?

AljazBozic commented 3 years ago

Hi! True, we were always using pytorch 1.4. Unfortunately versions <=1.2 don't provide the parameters align_corners, and the default internal setting seems to not be consistent between interpolate and grid_sample methods, so we can only recommend to use pytorch 1.4. Hope that helps!

maorp commented 3 years ago

maybe the yml needs update or a windows version. with cudatoolkit=10.0 it auto installs pytorch 1.2 at least on windows. thanks again!

pablopalafox commented 3 years ago

Hi @maorp, you can also have a look at this issue https://github.com/sniklaus/pytorch-pwc/issues/33, at the repo from which we took the pwcnet implementation in pytorch. In that issue, @sniklaus refers to pytorch/pytorch#23923.

pablopalafox commented 3 years ago

maybe the yml needs update or a windows version. with cudatoolkit=10.0 it auto installs pytorch 1.2 at least on windows. thanks again!

good point, could you try again with the latest commit?

pablopalafox commented 3 years ago

hey @maorp, I guess we can close the issue for now. Please feel free to open it up again if things are not working.