search

Dejauxvue / YGOProxyGenerator

13 stars 6 forks source link

Good proxy maker, but no feedback on issues #13

Closed sentrywiz closed 2 years ago

sentrywiz commented 2 years ago

I like the YGO proxy maker, easy to use, good. But in many times it gets stuck because maybe a card name was entered wrongly, or it just doesn't give me any pdf until after refreshing the page. A small window for displaying errors might be useful

Dejauxvue commented 2 years ago

I think, we had this feature before. I don't know, where it went. I'll have a look into it this week.

Dejauxvue commented 2 years ago

Done. Can you double check and close the issue, if it works?

sentrywiz commented 2 years ago

Great, tested it again, it now shows the alert box .

I put few names wrong "Could not display " name1, name2 ... great, much better feedback. It redownloaded with the cards it did know, I wasn't expecting that. Maybe its better design than not downloading at all?

Either way great work!

Dejauxvue commented 2 years ago

You're right, that would be much better. But this way, it's more simple^^ Maybe I will do image caching when I have more time

sentrywiz commented 2 years ago

I could do one idea, based on how much javascript+PHP you know. For PHP I'd help out, but I've not experiemented with the YGOPro API.

  1. 3 Cyber Dragon
  2. 3 Cyber End Dragon

When I put newline, the API could read the name, and put the name in a link to YGOPRO website. It would probably require some sort of AJAX functionality with the API. Not sure if you even want to code it.

In the case of not finding the card, the link could be displayed in red instead.

This is one way it would be clear if you got a card name wrong.