search

Dekkonot / bitbuffer

A binary stream module for packing binary data in pure Lua
https://dekkonot.github.io/bitbuffer/
MIT License
44 stars 11 forks source link

Change writeSigned + writeFloat to include the sign bit in the writeUnsigned call #17

Closed Dekkonot closed 4 years ago

Dekkonot commented 4 years ago

Any calls to writeBit that we can avoid should be avoided -- writeSigned(32, 1) currently makes the internal call to writeUnsigned non-aligned, which is a performance concern at scale. The same concern applies to writeFloat.

Dekkonot commented 4 years ago

This change doesn't make any sense.