search

DelSkayn / reblessive

A heap allocated runtime for deeply recursive algorithms.
MIT License
18 stars 3 forks source link

Support Windows 7 #3

Open ziadalzarka opened 2 months ago

ziadalzarka commented 2 months ago

This crate defines the needed Rust version as 1.77 while it not being necessary. Why not downgrade to 1.75 and have Windows 7 supported as a plus? :)

I am suggesting this because I was trying to build SurrealDB for Windows 7 and I couldn't because of reblessive. I forked both crates and modified them to get my build and it worked without any issues.

DelSkayn commented 2 months ago

It seems strange to me that this crate works on an earlier version as it depends on the support for async recursion introduced in rust 1.77. This crate will compile on earlier versions but you can't use it, as any attempt to use the library will result in rust throwing an error that futures are infinite size before 1.77. Furthermore the lowest rust version supported by surrealdb is 1.80 so that also shouldn't build.

ziadalzarka commented 1 month ago

It built and worked perfectly 🤔

ziadalzarka commented 1 month ago

I can share the code and executable with you, maybe I missed something