search

DelSkayn / rquickjs

High level bindings to the quickjs javascript engine
MIT License
504 stars 63 forks source link

Consider adding MSRV to cargo.toml #162

Closed Sytten closed 1 year ago

Sytten commented 1 year ago

As far as I can tell the MSRV is 1.69 due to from_bytes_until_nul

DelSkayn commented 1 year ago

Hi! Thank you for raising a issue.

This is on my TODO list. I also plan to add a CI check to verify the MSRV. Furthermore, I am also planning to remove the use of from_bytes_until_nul since it's use is not really required and it raises MSRV by a lot.

katyo commented 1 year ago

@DelSkayn Seems we should use Cstr::from_bytes_with_nul or even Cstr::from_bytes_with_nul_unchecked because the string constants is always nul-terminaed in our case.

DelSkayn commented 1 year ago

I have added a msrv to the cargo.toml as well as added a CI check to make sure rquickjs stays compatible with that version. So I think think this issue is resolved.