search

DelSkayn / rquickjs

High level bindings to the quickjs javascript engine
MIT License
504 stars 63 forks source link

Using cross to generate bindings #163

Open Sytten opened 1 year ago

Sytten commented 1 year ago

Hi! I would like to help a bit on the maintenance side. I think the project could leverage cross-rs to reduce the maintenance burden of generating bindings across many targets. I used the method to generate the armv7 bindings: https://github.com/DelSkayn/rquickjs/compare/master...caido:dependency-rquickjs:caido and it could scale to other platforms too. Let me know what you think!

DelSkayn commented 1 year ago

Hi, I am glad you willing to help!

cross-rs seems like a good tool to generate bindings for less common platforms. What exactly are you proposing we use it for? The library currently only contains pre-generated binding files for the major platforms with the bindgen feature intended for less common platforms. Do you propose we add pre-generated bindings?

Sytten commented 1 year ago

Some people asked for it in another issue, but I used it to generated bindings for armv7 (raspberry pi). The BSD targets are also good. But its true that we dont need to generate for all.