search

DelSkayn / rquickjs

High level bindings to the quickjs javascript engine
MIT License
504 stars 63 forks source link

Compilation error in ARM #169

Closed Martin1887 closed 1 year ago

Martin1887 commented 1 year ago

The compilation of rquickjss-sys-0.3.0 fails in ARM aarch64 (in Pinebook Pro) with the following error:

image

Thanks.

DelSkayn commented 1 year ago

I think I fixed the problem, bindgen recently switched to using usize for C size_t type. But I found this to have lead to some problems where certain platforms size_t is a u64 instead of usize. So I changed the library to use size_t again.

Just to verify, what platform triple (for example aarch64-unknown-linux-gnu) is the Pinebook Pro?

Martin1887 commented 1 year ago

It's exactly aarch64-unknown-linux-gnu. Thanks!

Martin1887 commented 1 year ago

I have just tried it using the main git path as dependency and it works, so the issue can be closed.

However, a new release would avoid having to point to the main branch.

Thanks!

DelSkayn commented 1 year ago

I have just released a new version with the fix. 0.3.1 should no longer contain the bug.

Martin1887 commented 1 year ago

Thanks!