DelSkayn / rquickjs

High level bindings to the quickjs javascript engine
MIT License
431 stars 58 forks source link

Add iterator #320

Open Sytten opened 1 month ago

Sytten commented 1 month ago

This is my first attempt at https://github.com/DelSkayn/rquickjs/issues/318

Couple of points before reviewing:

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 81.02981% with 70 lines in your changes are missing coverage. Please review.

Project coverage is 68.75%. Comparing base (304db5d) to head (8b80197).

Files Patch % Lines
core/src/value/iterator/iterable.rs 70.33% 35 Missing :warning:
core/src/value/iterator.rs 88.69% 26 Missing :warning:
core/src/value/iterator/into_iter.rs 57.14% 9 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #320 +/- ## ========================================== + Coverage 68.31% 68.75% +0.43% ========================================== Files 83 86 +3 Lines 12237 12606 +369 ========================================== + Hits 8360 8667 +307 - Misses 3877 3939 +62 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Sytten commented 3 weeks ago

Gentle ping @DelSkayn, whenever you have time I just want to avoid it getting stale :)