DeleteSystem32 / gd-flac

FLAC module for the Godot game engine
MIT License
16 stars 5 forks source link

Some changes to use via git subrepo #4

Open fire opened 1 year ago

fire commented 1 year ago

Hi!

I did some changes for https://github.com/V-Sekai/V-Sekai.flac so that it compiles for Godot Engine 4.2 and through a git subrepo.

https://github.com/V-Sekai/godot/tree/vsk-flac-4.2

Thanks! Feel free to take what you need under your license.

fire commented 1 year ago

I removed allocation in the audio thread which is something banned by the audio maintainers and causing github actions test failures with misused memory.

https://github.com/V-Sekai/V-Sekai.flac/commit/73de59e803ade5cfeb49e52cd33f9ef7c04ca2f0

fire commented 7 months ago

I wasn't able to correct mono channels in an hour so it's possible to error out if channels != 2.