DelfiSpace / DelfiPQcore

0 stars 1 forks source link

switch(state_flag) is a wrong condition #55

Open StarCycle opened 2 years ago

StarCycle commented 2 years ago

image

In the situation of the figure above, the state flag is 00110110 and the last 2 bits indicate the slot is fully programmed. However, the "case full" branch will not be coverred. It will only be triggered if state_flag==00000010.

Line 716, 753, 793 have this problem

StarCycle commented 2 years ago

https://github.com/DelfiSpace/DelfiPQcore/blob/9e15f6c53f2400e0761cb6f53432710689a95594/SoftwareUpdateService.cpp#L722