DelftMercurians / cotix

Continuous-time, differentiable RL environments
MIT License
0 stars 1 forks source link

Refactor support function transformations #29

Closed knyazer closed 1 year ago

knyazer commented 1 year ago

Now instead of passing the whole shapes into collision detection logic, only the support computations functions are passed.

Then, the transformation of the coordinate systems can be done naively with simply wrapping the support into the transformation, and passing the wrapped support as a real one.

The only thing left is to figure out what precisely to do with HomogenousTransformer. I would be happy if you could come up with something better than the current transformer approach, but I don't there is anything, without sacrificing performance

knyazer commented 1 year ago

@mikhail-vlasenko I would appreciate if you could take a look

mikhail-vlasenko commented 1 year ago

when would it be the case that the support function passed to collision detection is not shape.get_support?

knyazer commented 1 year ago

when would it be the case that the support function passed to collision detection is not shape.get_support?

Exactly when using bodies collision detection methods: they use a support function, that is a local support function transformed into a different coordinate system