search

Delgan / loguru

Python logging made (stupidly) simple
MIT License
19.62k stars 695 forks source link

build: use pep517/pep621 #1140

Closed trim21 closed 4 months ago

trim21 commented 4 months ago

replace legacy setup.py with pyproject.toml pep517/pep621 config

Delgan commented 4 months ago

Thank you for modernizing the project @trim21!

I've made a few fix to the CI runners, can you try rebasing your PR please? However, I do not explain the failure for Python 3.6.

trim21 commented 4 months ago

Thank you for modernizing the project @trim21!

I've made a few fix to the CI runners, can you try rebasing your PR please? However, I do not explain the failure for Python 3.6.

would you mind enable this option in repo settings? so I can update branch in web-ui instead of local git client.

image

Delgan commented 4 months ago

would you mind enable this option in repo settings? so I can update branch in web-ui instead of local git client.

Done, thanks for the suggestion. :+1:

trim21 commented 4 months ago

I guess, ci failed because setuptools support python3.5/3.6 are very out-dated and doesn't support new feature we are using.

trim21 commented 4 months ago

at fitst I want to continue using setuptools but python3.5/3.6 are too old and setuptools support theee 2 versions missing some feature we need and doesn't have a full support for pep621.

So I have to use flit to make it work on these 2 versions.

If you want to continue using setuptools we need drop these 2 python versions first.

Delgan commented 4 months ago

Hum... Reading documentation about Flir it seems it does not support build step which might be a problem in the future if part of Loguru is rewritten in C. :confused:

trim21 commented 4 months ago

Hum... Reading documentation about Flir it seems it does not support build step which might be a problem in the future if part of Loguru is rewritten in C. 😕

as I mentioned, drop py3.5/3.6 and use setuptools

in the future

image

Delgan commented 4 months ago

Yes, let's do it that way. I was planning to drop support for older versions of Python when the C version would be implemented anyway. Assuming that ever happens...

Thanks for your work.

trim21 commented 4 months ago

no problem. I use this package a lot (almost every application project of mine), don't want to see it dead.

Delgan commented 4 months ago

Glad to know that Loguru is important to you! I agree that Loguru's development lacks activity compared to what I was aiming for, unfortunately. I'm trying to get back to it progressively. Thanks for your help, it's much appreciated.