search

Delicode / NI-mate-plugins

This repository holds the plugins for NI mate.
http://www.ni-mate.com
17 stars 7 forks source link

Removing 'animatable' option on the UI properties #12

Closed plachenko closed 3 years ago

plachenko commented 3 years ago

I wasn't able to figure this out yesterday but this patch removes the default 'animatable' option in the UI properties as a safegaurd. I don't feel users would want to keyframe any of these properties.

SirDifferential commented 3 years ago

Is there something in the Blender plugin guidelines about this kind of thing? I seem to remember back in the 2.5 days the motto was something about being able to animate everything in UI.

plachenko commented 3 years ago

I'm not sure if there are any hard-set rules against keeping UI elements animatable. It just doesn't seem intuitive to allow a user to key frame most of these properties. Port and Address doesn't seem to be intended for animation for instance and object type won't change unless you refresh the collection hierarchy which seems like a good way to crash blender... (I haven't tried it to be honest)

It doesn't hurt to keep them 'animatable' I suppose-- it just seems like a safegaurd for users that might accidentally press 'i' inadvertently on two separate frames and have no idea why the plugin might seem broken.

SirDifferential commented 3 years ago

I think we can keep it animatable. Thanks for the suggestion though!

plachenko commented 3 years ago

Sounds good