search

DeligenceTechnologies / Braintree-Payment-Gateway-for-Flutter

Braintree Payment plugin for Flutter apps from Deligence Technologies. This plugin lets you integrate Braintree Drop In payment UI in just 4 easy steps.
BSD 3-Clause "New" or "Revised" License
34 stars 27 forks source link

v1.2.3 conflicted with firebase google_sign_in (Android only) #30

Open energy6x6 opened 4 years ago

energy6x6 commented 4 years ago

When I use packages below - google sign-in auth works prefectly braintree_payment: 1.2.2 firebase_auth: ^0.15.4 google_sign_in: ^4.1.1

if I have changed braintree_payment to v1.2.3 - google sign-in auth is freezing for result await GoogleSignIn().signIn() waits all time

jameshp commented 4 years ago

Hi Anton, you have the same problem that i encountered with the last Version. The "fix" introduced, causes bugs in other plugins. GoogleSignIn starts an Activity and waits for result as you can see here https://github.com/flutter/plugins/blob/master/packages/google_sign_in/google_sign_in/android/src/main/java/io/flutter/plugins/googlesignin/GoogleSignInPlugin.java

but if the braintree plugin is registered first (which it is based on the plugin name i think), then the current braintree plugin version returns just "true" and sign in plugin never returns.

See here: https://github.com/DeligenceTechnologies/Braintree-Payment-Gateway-for-Flutter/issues/25#issuecomment-581658752, but the issue is still closed.

Michael

On Fri, 7 Feb 2020 at 02:06, Anton Petrusha notifications@github.com wrote:

When I use packages below - google sign-in auth works prefectly braintree_payment: 1.2.2 firebase_auth: ^0.15.4 google_sign_in: ^4.1.1

if I have changed braintree_payment to v1.2.3 - google sign-in auth is freezing for result await GoogleSignIn().signIn() waits all time

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/DeligenceTechnologies/Braintree-Payment-Gateway-for-Flutter/issues/30?email_source=notifications&email_token=AA5FTUYQDAAJFPCYJCTQ35LRBSXZRA5CNFSM4KRGWAEKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ILVWEGA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5FTU7AUTEVM7D3AHJV5EDRBSXZRANCNFSM4KRGWAEA .