search

DelineaXPM / SS-ADO-BuildTask

MIT License
3 stars 4 forks source link

Pass in comments? #36

Open brandonbrinkley opened 1 year ago

brandonbrinkley commented 1 year ago

When I use DSS manually, I usually have to provide a comment by policy as to why I am retrieving the secret. I assume that this extension task only works with secrets for which that policy is not enabled. My question, would it be possible to add a comment text box to the task config screen and thereby pass in a comment, even if only optional? Obviously, there is no text box for one now, but I think it would be useful to be able to correlate a secret retrieval with a pipeline run in the logs. For example, I could configure it to pass in a string containing the $(Build.BuildId) variable. Thanks!

cloudkitects commented 1 year ago

I have the same issue, I know the API is capable but I think this would be a great addition and don't want to fork to implement it.

cloudkitects commented 1 year ago

I forked and tweaked Configuration formatUrl API to pass in comments. I was able to publish the task and test it:

coludkitecs_delineass

cospeedster commented 11 months ago

Same issue here...

Maybe you can open a PR for that?

cospeedster commented 2 months ago

@cloudkitects Do you think you can open a PR here?

cloudkitects commented 1 month ago

@cospeedster my fork has too many branding customizations and it's fairly behind now. I'll try to get to it next month.

cospeedster commented 1 month ago

@cloudkitects That would be great :)