search

DelineaXPM / ansible-core-collection

Ansible collection for Delinea DevOps Secrets Vault
GNU General Public License v3.0
4 stars 1 forks source link

feat(plugins/lookup/dsv): support data filtering #39

Closed andrii-zakurenyi closed 1 year ago

andrii-zakurenyi commented 1 year ago

AB#487545

codecov[bot] commented 1 year ago

Codecov Report

Merging #39 (e72d5fc) into main (4df0f2e) will decrease coverage by 0.12%. The diff coverage is n/a.

:exclamation: Current head e72d5fc differs from pull request most recent head 4e2ed2e. Consider uploading reports for the commit 4e2ed2e to get more accurate results

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   89.28%   89.16%   -0.12%     
==========================================
  Files           2        2              
  Lines          84      120      +36     
  Branches        6        8       +2     
==========================================
+ Hits           75      107      +32     
- Misses          8       12       +4     
  Partials        1        1

see 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

andrii-zakurenyi commented 1 year ago

@sheldonhull I've tried to also add a new change via changie, but it feels odd to have both CHANGELOG.rst and CHANGELOG.md managed by two different tools. Therefore for now I did not included changie updates in this PR. Use --force if you want me to do it :)

sheldonhull commented 1 year ago

Looking now as I thought i made some notes on this in the past, but maybe not! Definitely don't want double work. Give me a minute.

andrii-zakurenyi commented 1 year ago

So basically try to reword the release summary to be slightly more descriptive to a consumer of the Ansible plugin.

@sheldonhull can you please help me with this please?

Is the double backticks required in the yaml file for data_key as that's not normal markdown, but maybe it's ok for RST?

I've found this convention here: https://docs.ansible.com/ansible/devel/community/collection_development_process.html#creating-a-changelog-fragment

Lastly, i glanced at the release workflow and it doesn't show anything other than python setup.

Yes, this part is not automated.

andrii-zakurenyi commented 1 year ago

Ok so if you don't mind put a note in the readme for ## Release and mention mage ansible:changelog

there: https://github.com/DelineaXPM/ansible-core-collection/pull/42