Closed andrii-zakurenyi closed 1 year ago
Less than a hundred lines of logs for that "build-and-publish" step. Charming :sparkles:
Not sure what should be the trigger of this workflow though :thinking:
Will it be good enough? :man_shrugging:
on:
push:
tags:
- v*
@andrii-zakurenyi included some other tasks to help with this, as ideally you can run locally the same as remote. These changes include:
yq
bump the galaxy yaml version as part of development.I'm ok merging this as is now to break things into smaller pieces, but there's one last thing to look at afterward... does ansible-galaxy
publishing actually create a github release? If not then we can either look at using the github action that does the build and workflow creation, OR we add a github release via gh release create
invocation to the mage release process that uses the semver bump. gh release
actually adds the tag for us so we don't push manual tags anymore. Makes it nice for the release logs.
Almost no github repos get manual tags due to this github release tag creation process.
Also the token for github release, we can use our team vault and pull or for simplicity we can add as a github secret attached to this.
flipped to draft as do-not-merge
is not a blocking condition. I'll catch up next week with you and if you want to pair on anything to wrap it up just let me know. Cheers
Haven't forgotten about this. Will review soon as lots of changes and want to observe the improvements you made. Cheers
Merging. Will handle further review or changes for docs in a different PR. Thank you for this hard work @andrii-zakurenyi
Updates to GitHub workflows:
test-unit
andtest-sanity
workflows.test
workflow which usesmage
to init, test and build coverage report.release
workflow which usesmage
to run sanity check, then build and publish the collection.Updates to Magefile:
Output of
mage -l
command:AB#500727