DelineaXPM / terraform-provider-dsv

A Terraform Provider for Delinea DevOps Secrets Vault
https://delinea.com/products/devops-secrets-management-vault
MIT License
6 stars 3 forks source link

SecretID is hardcoded in readme file #21

Closed tylerezimmerman closed 1 year ago

tylerezimmerman commented 2 years ago

Description of the issue

SecretID is hardcoded in readme file

Expected behavior

Secret should be fetched from vault or other secure method

Actual behavior

Credential is hardcoded.

Steps to reproduce

image

sheldonhull commented 2 years ago

tfvars are typically not included in github commits, but yes, maybe a better example could be provided for alternative approaches. Since this also can change based on the Terraform cloud secure variables or the provider I'll think on how to provide some examples here. thanks for bringing this up.