Add deletion secret - Githubissues

DelineaXPM / terraform-provider-tss

MIT License

6 stars 3 forks source link

Add deletion secret #57

Closed jbatmalle closed 6 months ago

jbatmalle commented 7 months ago

name: Add deletion secret about: feature

Pull request checklist

Please check if your PR fulfills the following requirements:

[ ] You have read the contributing guide
[X] Tests for the changes have been added
[ ] The documentation has been reviewed and updated as needed

What is the current behavior?

The secret is not deleted

What is the new behavior?

The secret is deleted

Does this introduce a breaking change?

[ ] Yes
[X] No

Other relevant information

delineaKrehl commented 7 months ago

@jbatmalle can you also add a secret_delete example to go along with this add?

jbatmalle commented 6 months ago

Hi @delinea-sagar and @delineaKrehl, Sorry for the delay I don't quite understand what you want Terraform manage ressource destruction and we can't create a tf file with that The only way is to use the count directive but that won't be clear to users

delinea-sagar commented 6 months ago

@jbatmalle After executing the 'terraform destroy' command, will dataSourceSecretDelete be automatically invoked?

jbatmalle commented 6 months ago

Hi @delinea-sagar , Yes of course, when you manage your secrets using terraform, if you destroy your ressource the function will be called These are basic terraform functions (create, update, delete) and there is no need to explain this behaviour