DelineaXPM / tss-sdk-go

A Golang SDK for Delinea Secret Server
https://delinea.com/products/secret-server
MIT License
2 stars 9 forks source link

Fix(api) added configuration.apiVersion to all secret server API calls #27

Open pacificcode opened 5 months ago

pacificcode commented 5 months ago

Added configuration.apiVersion to all secret server API calls. Fixed code so all linters run successfully Fixed unit tests to work with newest versions of SS api calls and to run successfully.

Pull request checklist

Please check if your PR fulfills the following requirements:

What is the current behavior?

Currently all API calls to secret server are using api/v1 ... some of these API's have been updated to api/v2.

What is the new behavior?

Does this introduce a breaking change?

If yes, please describe...

Other relevant information

pacificcode commented 5 months ago

@tylerezimmerman There seems to be an issue setting ENV var values. Would you happen to know anything about this?

sheldonhull commented 5 months ago

@delinea-sagar @DelineaXPM/ss-write can someone take a look at environmental variables failure for @pacificcode since they were changed last month I see he's getting failures on these.

delinea-sagar commented 5 months ago

With the inclusion of platform login support, it's necessary to configure environment variables for platform details in order to execute tests. Use same secret server which is configured with platform. This ensures consistency in details such as secret ID and folder ID for running test cases directly on the secret server instance as well as via the platform. image

sheldonhull commented 4 months ago

instance

I checked and didn't see TSS_SERVER_URL set in the actions secrets. Mind double checking and let @pacificcode know more specifically what he might be missing if it's something else?

Also note this test seems to have failed in earlier PRs as well, see this check from prior pr