Open MeikelLP opened 6 years ago
Hi there, I'm not accepting this PR yet, it need some more work :
filters.vue
:
There may be some version incompatibility with Bulma, as some visuals look weird (unsaved icon is huuuuge and icon-only buttons are wider than high instead of square)
filters.vue
? This file does not exist.⚠️ We must create database migration for the icons. I don't know why but storing the FontAwesome icon name as the state of an operation is pretty bad IMHO.
This must be migrated to a new state. For overview purposes, I highly recommend doing this in a sperate PR but as a blocker. No productive release until this migration is done (otherwise may make old databases unusable).
Yep sorry for the mistake, I was talking about src/renderer/components/MainPane/accountsDetails/filterBar.vue
Concerning the button without icon, it is ok now. Maybe some misfunctionning on my side (on icon maybe had some trouble loading ¯_(ツ)_/¯)
I strongly agree with the fact of changing the way the state is stored, it is wobbly since the first release. However I don't know how to run the migration script. Ask the user to commit the action ? Look for database integrity on each boot and run if compromised ?
For the migration please refer to #17
[CHG] Upgraded to Fontawesome 5 [ADD] Vue-Fontawesome for SVG icons (more performance in standalone apps) [CHG] Upgraded bulma 0.7.0 -> 0.7.1