search

Delogrand770 / champGG

Downloads the latest item sets from champion.gg for League of Legends
5 stars 2 forks source link

I'm getting all these wonderful errors #2

Closed Italist closed 9 years ago

Italist commented 9 years ago

wbsyfjt

Delogrand770 commented 9 years ago

Those errors mean your internet connection is having difficulty connecting to the website champion.gg. This can be caused by a slow, disrupted or blocked internet connection.

Italist commented 9 years ago

Could you delay the time it waits for the server response and/or give some delay between server requests? My connection is pretty solid. Imo it was the server rejecting the connection.

Delogrand770 commented 9 years ago

The program is build on nwjs.io and it uses a built in nodejs library so I don't think I can extend the timeout request. I can try adding a delay between requests. I use the program daily but then again my setup is different then yours so thanks for helping me improve reliability by reporting the errors you see.

On Fri, Apr 17, 2015 at 4:31 PM Italist notifications@github.com wrote:

Could you delay the time it waits for the server response and/or give some delay between server requests? My connection is pretty solid. Imo it was the server rejecting the connection.

— Reply to this email directly or view it on GitHub https://github.com/Gavin770/champGG/issues/2#issuecomment-94088762.

Italist commented 9 years ago

That would be awesome! Thanks to you for making this version of the script and taking time to assist me. I'd have contributed with a push myself but I'm not familiar with the tech you used.

By the way you may find useful for further development this discussion over the skillorder: https://www.reddit.com/r/leagueoflegends/comments/32ea2b/championgg_item_sets_updated_for_patch_57_script/cqanzco

I'd personally use the last comment on that tree. Oh by the way, I noticed the ebildude123 guy removed the mana pot for mana less champs on his itemsets generator. Thanks again.

Delogrand770 commented 9 years ago

The new version now has a one request at a time mode. You can enable it by clicking the config button and following the last sections instructions.

Italist commented 9 years ago

Tried it out, it worked like a charm!

Delogrand770 commented 9 years ago

I also just implemented the skill order changes you pointed out on reddit. I didn't remove the mana pot from non ap champs that way when people try weird builds they have it at their disposal.

Italist commented 9 years ago

OP! You are now exalted with Italist.

Delogrand770 commented 9 years ago

Thanks! Also you should know I updated it again to prevent the titles of each item section from being cut off. Turns out the League client has a 50 character limit.