search

Delogrand770 / champGG

Downloads the latest item sets from champion.gg for League of Legends
5 stars 2 forks source link

Space at end of folder name #8

Closed mphartzheim closed 9 years ago

mphartzheim commented 9 years ago

The current data set is being downloaded and put into a folder with a space at the end of the folder name.

"\ItemSets\22 JUN 2015 - PATCH \"

The space on the end does not play nicely with Windows. Namely, you cannot rename or delete the folder as Windows says that it cannot find the folder.

Delogrand770 commented 9 years ago

Nice catch, I'll get a fix out ASAP

On Mon, Jun 22, 2015 at 7:05 PM mphartzheim notifications@github.com wrote:

The current data set is being downloaded and put into a folder with a space at the end of the folder name.

"\ItemSets\22 JUN 2015 - PATCH \"

The space on the end does not play nicely with Windows. Namely, you cannot rename or delete the folder as Windows says that it cannot find the folder.

— Reply to this email directly or view it on GitHub https://github.com/Gavin770/champGG/issues/8.

Delogrand770 commented 9 years ago

So the problem was champion.gg changed their HTML for how they showed the current patch. This caused the HTML scrape to fail and I never thought of that happening. I updated the app to find the new patch version and I fixed it from ever putting trailing spaces again if (when) they change their site HTML.

Delogrand770 commented 9 years ago

Steps to remove a bugged ItemSets directory

  1. Right click near but not on the ItemSets folder while holding shift
  2. Select "Open Command Window Here"
  3. Type the command below and press enter

rd /s /q ItemSets