search

DeloitteAU / rhythm-ui

A UI framework for creating Design Systems
Other
5 stars 10 forks source link

Allow projects to define where styles is resolved from #104

Closed jennasalau closed 5 years ago

jennasalau commented 5 years ago

This PR addresses an issue when running the canary version of RUI and resolving the styles component. It will allow the project to define how styles is defined.

MicrosoftTeams-image

kaiyangl commented 5 years ago

@jennasalau Should we still have it in devdependencies if we already have it in peerdependencies?

jennasalau commented 5 years ago

Yeah we should, did i miss it in a place?

kaiyangl commented 5 years ago

Just checking that the duplication is intentional :)

jennasalau commented 5 years ago

Ahh yep.. peerDependencies requires a manual install always.

Often we define a "range" in peerDepenencies but use a very specific version during dev.. we define that version in devDependencies so we dont have to do any manual installs during development

kaiyangl commented 5 years ago

Ah ok got it, thanks for explaining