search

DeloitteDigitalUK / react-redux-starter-app

Starter app with React, Redux, Webpack, CSS Modules, API calls etc.
MIT License
16 stars 0 forks source link

Connect Travis CI #20

Closed vitkon closed 7 years ago

vitkon commented 8 years ago

surface issues early

michael-martin commented 7 years ago

@vitkon @mattdell So I reverted on the npm run lint question on the start task... :(

I spent a while fighting with the linter configuration locally today due to first the airbnb-config-base package not being updated for me locally when the rest of the packages were, and then for a while after I'd fixed things because I needed to re-open the project in Atom for it to pick up the changes.

Those are exactly the kind of issues that developers new to React shouldn't have to worry about. If that was happening to them, I'd rather they could get the app up and running and play with it, and then ask here for support.

However, in return, I promise I'll set up this CI this week or next so we still get properly enforced linting before anything gets into master!

Does that seem reasonable?

michael-martin commented 7 years ago

@vitkon @mattdell Decided to do tonight, didn't realise the starter kit already had the travis yml file in it!

Added a pretty little green button to our readme.md as well now :)

vitkon commented 7 years ago

I agree with @mattdell and think that we need it earlier than CI and it should be on by default, however there should be a task that allows to skip the checks and lets you play with it. e.g. npm run quickstart

Happy to discuss further