Closed michael-martin closed 8 years ago
nice!
On 14 August 2016 at 17:12, Michael Martin notifications@github.com wrote:
Fixes #1 https://github.com/DeloitteDigitalUK/react-redux-starter-app/issues/1
(cc @vitkon https://github.com/vitkon - Finally some linting is
possible! :) )
You can view, comment on, or merge this pull request online at:
https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23 Commit Summary
- adds eslint3 wih airbnb preset
- auto-corrections from lint:fix
- adds build directory to linter. Includes auto-corrections
- fixes more eslint issues
- Merge branch 'master' into Eslint3
- updates eslint deps, and extends on airbnbs react rules
- fixes first tranch of eslint issues
- resolves the rest of the eslint issues
File Changes
- M .eslintrc https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-0 (9)
- M build/karma.conf.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-1 (53)
- M build/webpack-compiler.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-2 (43)
- M build/webpack.config.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-3 (154)
- M config/environments.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-4 (14)
- M config/index.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-5 (65)
- M package.json https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-6 (22)
- M server/lib/apply-express-middleware.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-7 (17)
- M server/main.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-8 (53)
- M server/middleware/webpack-dev.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-9 (35)
- M server/middleware/webpack-hmr.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-10 (21)
- M src/components/CardView/CardView.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-11 (5)
- M src/components/CardView/index.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-12 (3)
- M src/components/Counter/Counter.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-13 (16)
- M src/components/Counter/index.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-14 (4)
- M src/components/Header/Header.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-15 (30)
- M src/components/Header/index.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-16 (3)
- M src/components/RepoList/RepoList.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-17 (8)
- M src/components/RepoList/RepoListStories.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-18 (4)
- M src/components/RepoList/index.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-19 (3)
- M src/components/Search/Search.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-20 (80)
- M src/components/Search/SearchStories.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-21 (77)
- M src/components/TextQuestion/TextQuestion.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-22 (2)
- M src/components/TextQuestion/index.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-23 (3)
- M src/components/WeatherView/WeatherFixture.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-24 (172)
- M src/components/WeatherView/WeatherStories.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-25 (2)
- M src/components/WeatherView/WeatherView.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-26 (38)
- M src/containers/AppContainer.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-27 (42)
- M src/containers/RepositoriesContainer/RepositoriesContainer.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-28 (10)
- M src/containers/RepositoriesContainer/RepositoriesDucks.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-29 (54)
- M src/containers/SearchContainer/SearchContainer.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-30 (44)
- M src/containers/SearchContainer/SearchDucks.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-31 (48)
- M src/containers/WeatherContainer/WeatherContainer.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-32 (26)
- M src/containers/WeatherContainer/WeatherDucks.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-33 (54)
- M src/layouts/CoreLayout/CoreLayout.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-34 (18)
- M src/layouts/CoreLayout/index.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-35 (4)
- M src/main.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-36 (52)
- M src/routes/Home/Home.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-37 (10)
- M src/routes/Home/index.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-38 (3)
- M src/routes/Weather/index.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-39 (3)
- M src/store/createStore.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-40 (31)
- M src/store/reducers.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-41 (34)
- M src/utils/ApiUtils.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-42 (17)
- M tests/test-bundler.js https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23/files#diff-43 (37)
Patch Links:
- https://github.com/DeloitteDigitalUK/react-redux- starter-app/pull/23.patch
- https://github.com/DeloitteDigitalUK/react-redux- starter-app/pull/23.diff
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/DeloitteDigitalUK/react-redux-starter-app/pull/23, or mute the thread https://github.com/notifications/unsubscribe-auth/ABokzFO9cRR0qBS2vTUReycclzWF5--tks5qfz5TgaJpZM4Jj7bR .
Best regards
Vitaly Kondratiev
Fixes #1
(cc @vitkon - Finally some linting is possible! :) )