DeloitteOptimalReality / LightOSM.jl

A Julia package for downloading and analysing geospatial data from OpenStreetMap APIs.
https://deloitteoptimalreality.github.io/LightOSM.jl/docs
Other
48 stars 13 forks source link

Fix lane parsing bug #102

Closed simsurace closed 7 months ago

simsurace commented 7 months ago

Parsing railways fails on master:

graph = graph_from_download(
    :place_name; place_name="bern, switzerland", network_type=:rail, weight_type=:distance
)

This PR fixes this bug by using the lanes function in the railway branch. I also added a regression test. Could we get a release with this bugfix? If v0.3.0 is being blocked, maybe we could backport this bugfix onto v0.2.x?

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.53%. Comparing base (c30254c) to head (c06c573).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #102 +/- ## ========================================== + Coverage 81.05% 84.53% +3.47% ========================================== Files 15 15 Lines 1151 1151 ========================================== + Hits 933 973 +40 + Misses 218 178 -40 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

simsurace commented 7 months ago

Great thanks! Would be great if you could release this bugfix.

captchanjack commented 7 months ago

Done!