DeloitteOptimalReality / LightOSM.jl

A Julia package for downloading and analysing geospatial data from OpenStreetMap APIs.
https://deloitteoptimalreality.github.io/LightOSM.jl/docs
Other
47 stars 12 forks source link

precomputing dijkstra_states throws an UndefVarError #87

Open ctlbau opened 1 year ago

ctlbau commented 1 year ago

From https://github.com/DeloitteOptimalReality/LightOSM.jl/blob/master/benchmark/benchmarks.jl

point = GeoLocation(-37.8142176, 144.9631608) # Melbourne, Australia
radius = 5 # km
data_file = joinpath(@__DIR__, "benchmark_map.osm")

g_losm = LightOSM.graph_from_download(:point,
                                      point=point,
                                      radius=radius,
                                      weight_type=:distance,
                                      download_format=:osm,
                                      save_to_file_location=data_file)

# g_losm = LightOSM.graph_from_file(data_file, weight_type=:distance)
@time g_losm_precompute = LightOSM.graph_from_file(data_file, weight_type=:distance, precompute_dijkstra_states=true)

throws and UndefVarError blaming a parameter n in src/graph.jl:455 which simply initialises a vector to hold g.dijkstra_states = Vector{Vector{U}}(undef,n) Shouldn't this be g.dijkstra_states = Vector{Vector{U}}(undef,length(g.nodes)) ?

https://github.com/DeloitteOptimalReality/LightOSM.jl/blob/33898b9b45728878546ac22775347e7ae2459dd2/src/graph.jl#L456