search

DeloitteOptimalReality / LightOSM.jl

A Julia package for downloading and analysing geospatial data from OpenStreetMap APIs.
https://deloitteoptimalreality.github.io/LightOSM.jl/docs
Other
48 stars 13 forks source link

[FIX] Ensure "lanes" tag for railway type is converted to Int8 #93

Closed captchanjack closed 1 year ago

captchanjack commented 1 year ago

Fixes parsing issue when dealing with railway networks, this commit will ensure lanes are converted to the required type (Int8)

Should #51

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.21 :tada:

Comparison is base (d9dda71) 79.87% compared to head (ac52c93) 80.08%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #93 +/- ## ========================================== + Coverage 79.87% 80.08% +0.21% ========================================== Files 14 15 +1 Lines 1133 1135 +2 ========================================== + Hits 905 909 +4 + Misses 228 226 -2 ``` | [Impacted Files](https://codecov.io/gh/DeloitteOptimalReality/LightOSM.jl/pull/93?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/parse.jl](https://codecov.io/gh/DeloitteOptimalReality/LightOSM.jl/pull/93?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3BhcnNlLmps) | `89.41% <50.00%> (+0.58%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://codecov.io/gh/DeloitteOptimalReality/LightOSM.jl/pull/93/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jarodlam commented 1 year ago

Need to see how this interacts with #90. This PR fixed some logic with how we parse the lanes tag as well, and it might be relevant here