search

DelphiPackageManager / DPM

A Package Manager for Delphi
Apache License 2.0
96 stars 21 forks source link

Fix issues for compiling in D10 and D10.3.3 #11

Closed pipcom closed 4 years ago

pipcom commented 4 years ago

First i had a few issues when compiling DPM with D10. I manually added the libraries and the dependencies in the project files without defining $(DPMSearch). Anyway. I found something in the documentation that describes how to setup DPM with linking dependencies in source\libs via mklink.exe command. Nice idea. I wrote a prepare.cmd batch script to setup the environment. Together with Project files using relative dependencies in source libs i was able to compile without having to prepare something in the IDE. May be you find this usefull and merge this.

The second commit is about a compiling issue on Source/Core/Package/DPM.Core.Package.Installer.pas. First i thought D10 is to old for this but i had the same issue compiling unter D10.3.3. Not sure, but it may be a compiler setting in your delphi version. Anyway, i found out that removing the const declaration in the anonymous function was solving the issue. Feel free to merge or discuss.

pipcom commented 4 years ago

Ok, i changed the clone line for spring4d and deleted the other files from this request. I hope this will not delete files on merge 👍

pipcom commented 4 years ago

Sorry wrong button. i have no experience with working on pull requests. This is my second one 👍

vincentparrett commented 4 years ago

It looks like removing the dproj files from the PR is actually attempting to delete the files. It might be best to cancel this PR and create a new one. Take a backup of the batch file and then start fresh.